Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #199

Merged
merged 15 commits into from
Oct 10, 2023
Merged

Update dependencies #199

merged 15 commits into from
Oct 10, 2023

Conversation

djc
Copy link
Contributor

@djc djc commented Oct 9, 2023

Would be nice to get this in a release.

Given the lack of activity, what will maintenance be like going forward?

@sebpuetz
Copy link
Member

sebpuetz commented Oct 9, 2023

Given the lack of activity, what will maintenance be like going forward?

I'm happy to review changes / dependency updates, I haven't been using the library (or rather anything in the project) for a couple of years so nothing has been driving active development.

I'll try to go through the other repos during the week and take care of some updates.

@djc
Copy link
Contributor Author

djc commented Oct 9, 2023

Thanks for the quick response!

@djc
Copy link
Contributor Author

djc commented Oct 9, 2023

Looks like the mips64 target is not available for Rust 1.72: rust-lang/rust#115218.

Let me know how you want this handled?

@sebpuetz
Copy link
Member

sebpuetz commented Oct 9, 2023

Looks like the mips64 target is not available for Rust 1.72: rust-lang/rust#115218.

Let me know how you want this handled?

After a cursory look at the issue, it looks like RustCrypto is using PPC32 as an alternate BE target: RustCrypto/sponges#62

I believe our intention was to test BE targets, too, so that should be a viable alternative

@djc djc force-pushed the update-deps branch 4 times, most recently from 0bb1b11 to b7c3bd9 Compare October 9, 2023 09:01
@djc
Copy link
Contributor Author

djc commented Oct 9, 2023

I added a version bump to 0.18, since some of the dependencies that got bumped are visible in the public API.

@danieldk
Copy link
Member

danieldk commented Oct 9, 2023

I'm happy to review changes / dependency updates, I haven't been using the library (or rather anything in the project) for a couple of years so nothing has been driving active development.

Same here, I don't use finalfusion/finalfrontier anymore, but am happy to review stuf

src/chunks/metadata.rs Outdated Show resolved Hide resolved
src/compat/fasttext/io.rs Outdated Show resolved Hide resolved
Copy link
Member

@sebpuetz sebpuetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danieldk danieldk merged commit 6669c74 into finalfusion:main Oct 10, 2023
8 checks passed
@djc
Copy link
Contributor Author

djc commented Oct 10, 2023

Thanks! Are there any other blockers to getting this published on crates.io?

@danieldk
Copy link
Member

Thanks! Are there any other blockers to getting this published on crates.io?

Nope, I'll get to it now.

@danieldk
Copy link
Member

Done, thanks for making this happen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants